Re: [libvirt] [PATCH 06/10] list: Add helper to convert strings separated by ', ' to array

2012-09-06 Thread Osier Yang
On 2012年09月06日 00:24, Eric Blake wrote: On 09/04/2012 09:16 AM, Osier Yang wrote: tools/virsh.c: New helper function vshStringToArray. tools/virsh.h: Declare vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++-

Re: [libvirt] [PATCH 06/10] list: Add helper to convert strings separated by ', ' to array

2012-09-06 Thread Eric Blake
On 09/06/2012 08:38 AM, Osier Yang wrote: allow for users to input ',,' for a literal comma that does not separate options? If so, then we should merge in the double comma handling from vshParseSnapshotDiskspec (virsh-snapshot.c) into this function, and have that function also refactored to

Re: [libvirt] [PATCH 06/10] list: Add helper to convert strings separated by ', ' to array

2012-09-05 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: tools/virsh.c: New helper function vshStringToArray. tools/virsh.h: Declare vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++- tools/virsh.c| 44

[libvirt] [PATCH 06/10] list: Add helper to convert strings separated by ', ' to array

2012-09-04 Thread Osier Yang
tools/virsh.c: New helper function vshStringToArray. tools/virsh.h: Declare vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++- tools/virsh.c| 44 tools/virsh.h|