Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-28 Thread Eric Blake
On 02/27/2013 11:32 PM, TJ wrote: One thing I'm not yet sure how to deal with is the difference between build and deployment systems when one or the other doesn't have access to 'dhcp-helper', since as I understand it, some distributions do not include it in their package archives (it is

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-28 Thread Laine Stump
On 02/27/2013 09:57 PM, TJ wrote: From: TJ li...@iam.tj A DHCP relay daemon will be started that will forward all DHCP/BOOTP requests on the bridge network via the first declared forward interface. Okay, I think we've got our first candidate for something we might want to configure. Picking

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-28 Thread Laine Stump
On 02/28/2013 01:32 AM, TJ wrote: That then leaves the issue of different DHCP relay agents requiring different command-line parameters. I was looking at the discussion about the option element and wondering if that could have a dual use here, especially in the name= variety, e.g: ip ...

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-28 Thread TJ
On 28/02/13 19:56, Laine Stump wrote: On 02/27/2013 09:57 PM, TJ wrote: From: TJ li...@iam.tj A DHCP relay daemon will be started that will forward all DHCP/BOOTP requests on the bridge network via the first declared forward interface. Okay, I think we've got our first candidate for

[libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-27 Thread TJ
From: TJ li...@iam.tj A DHCP relay daemon will be started that will forward all DHCP/BOOTP requests on the bridge network via the first declared forward interface. The relay is broadcast rather than routed so no IP address is needed on the bridge. The XML relay element's relay property of the

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-27 Thread Eric Blake
On 02/27/2013 07:57 PM, TJ wrote: From: TJ li...@iam.tj A DHCP relay daemon will be started that will forward all DHCP/BOOTP requests on the bridge network via the first declared forward interface. The relay is broadcast rather than routed so no IP address is needed on the bridge. The

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-27 Thread TJ
On 28/02/13 03:38, Eric Blake wrote: This indentation mess with TAB is making this hard to review. It seems vim is the culprit. Default setting seems to be that it's inserting a tab when I hit Enter on a previous line when there's a multiple of 8 spaces of indent on the new line. I had a

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-27 Thread Eric Blake
On 02/27/2013 07:57 PM, TJ wrote: From: TJ li...@iam.tj A DHCP relay daemon will be started that will forward all DHCP/BOOTP requests on the bridge network via the first declared forward interface. The relay is broadcast rather than routed so no IP address is needed on the bridge.

Re: [libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

2013-02-27 Thread TJ
On 28/02/13 04:09, Eric Blake wrote: On 02/27/2013 07:57 PM, TJ wrote: From: TJ li...@iam.tj A DHCP relay daemon will be started that will forward all DHCP/BOOTP requests on the bridge network via the first declared forward interface. The relay is broadcast rather than routed so no IP