Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 02:50 PM +0200, Peter Krempa wrote: > On Mon, Oct 01, 2018 at 14:38:40 +0200, Marc Hartmayer wrote: >> On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa >> wrote: >> > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: >> >> On Sat, Sep 29, 2018 at 04:09 AM

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 14:38:40 +0200, Marc Hartmayer wrote: > On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa > wrote: > > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: > >> On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan > >> wrote: > >> > On 9/20/18 1:44 PM, Marc Ha

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa wrote: > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: >> On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan >> wrote: >> > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> >> Move the domainPostParseDataAlloc/Free calls to >> >>

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: > On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan > wrote: > > On 9/20/18 1:44 PM, Marc Hartmayer wrote: > >> Move the domainPostParseDataAlloc/Free calls to > >> virDomainDeviceDefParse. As an consequence > >> virDomainDeviceDefPo

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Marc Hartmayer
On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan wrote: > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> Move the domainPostParseDataAlloc/Free calls to >> virDomainDeviceDefParse. As an consequence >> virDomainDeviceDefPostParseOne is superfluous and can therefore be >> removed. >> >> Signed-off

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-09-28 Thread John Ferlan
On 9/20/18 1:44 PM, Marc Hartmayer wrote: > Move the domainPostParseDataAlloc/Free calls to > virDomainDeviceDefParse. As an consequence > virDomainDeviceDefPostParseOne is superfluous and can therefore be > removed. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > s

[libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-09-20 Thread Marc Hartmayer
Move the domainPostParseDataAlloc/Free calls to virDomainDeviceDefParse. As an consequence virDomainDeviceDefPostParseOne is superfluous and can therefore be removed. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/conf/domain_conf.c | 37 +++-