Re: [libvirt] [PATCH 06/14] conf: Drop virDomainChrDeviceType.targetTypeAttr

2017-11-16 Thread Pavel Hrdina
On Wed, Nov 15, 2017 at 12:50:09PM +0100, Andrea Bolognani wrote: > This attribute was used to decide whether to format the type > attribute of the element, but the logic didn't take into > account all possible cases and as such could lead to unexpected > results. Moreover, it's one more thing to

[libvirt] [PATCH 06/14] conf: Drop virDomainChrDeviceType.targetTypeAttr

2017-11-15 Thread Andrea Bolognani
This attribute was used to decide whether to format the type attribute of the element, but the logic didn't take into account all possible cases and as such could lead to unexpected results. Moreover, it's one more thing to keep track of, and can easily fall out of sync with other attributes.