Re: [libvirt] [PATCH 06/14] driver: tighten check for whether loadable module exists or not

2018-04-24 Thread Michal Privoznik
On 04/19/2018 07:09 PM, Daniel P. Berrangé wrote: > Currently we do a access(R_OK) check to see whether a loadable module > exists, treating failure as non-fatal. This is unreasonably loose, as a > module which exists but has had incorrect permissions set will turn into > a silent skip. We only

[libvirt] [PATCH 06/14] driver: tighten check for whether loadable module exists or not

2018-04-19 Thread Daniel P . Berrangé
Currently we do a access(R_OK) check to see whether a loadable module exists, treating failure as non-fatal. This is unreasonably loose, as a module which exists but has had incorrect permissions set will turn into a silent skip. We only want to skip loading if the module genuinely does not exist