Re: [libvirt] [PATCH 06/19] qemu_agent: Resolve Coverity RESOURCE_LEAK

2014-08-28 Thread Wang Rui
On 2014/8/28 17:03, Ján Tomko wrote: > On 08/28/2014 04:40 AM, Wang Rui wrote: >> On 2014/8/28 4:54, John Ferlan wrote: >>> Coverity found that on error paths, the 'arg' value wasn't be cleaned >>> up. Followed the example in qemuAgentSetVCPUs() where upon successful call >>> to qemuAgentCommand()

Re: [libvirt] [PATCH 06/19] qemu_agent: Resolve Coverity RESOURCE_LEAK

2014-08-28 Thread Ján Tomko
On 08/28/2014 04:40 AM, Wang Rui wrote: > On 2014/8/28 4:54, John Ferlan wrote: >> Coverity found that on error paths, the 'arg' value wasn't be cleaned >> up. Followed the example in qemuAgentSetVCPUs() where upon successful call >> to qemuAgentCommand() the 'cpus' is set to NULL; otherwise, when

Re: [libvirt] [PATCH 06/19] qemu_agent: Resolve Coverity RESOURCE_LEAK

2014-08-27 Thread Wang Rui
On 2014/8/28 4:54, John Ferlan wrote: > Coverity found that on error paths, the 'arg' value wasn't be cleaned > up. Followed the example in qemuAgentSetVCPUs() where upon successful call > to qemuAgentCommand() the 'cpus' is set to NULL; otherwise, when cleanup > occurs the free the memory for 'arg

[libvirt] [PATCH 06/19] qemu_agent: Resolve Coverity RESOURCE_LEAK

2014-08-27 Thread John Ferlan
Coverity found that on error paths, the 'arg' value wasn't be cleaned up. Followed the example in qemuAgentSetVCPUs() where upon successful call to qemuAgentCommand() the 'cpus' is set to NULL; otherwise, when cleanup occurs the free the memory for 'arg' Signed-off-by: John Ferlan --- src/qemu/q