Re: [libvirt] [PATCH 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 15:41 +0200, Peter Krempa wrote: > > > +/* Biggest value we can expect to be used as either socket id > > + * or core id. Bitmaps will need to be sized accordingly */ > > +const int ID_MAX = 4095; > > I think this should be a more global setting. We have quite a

Re: [libvirt] [PATCH 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:26 +0200, Andrea Bolognani wrote: > Swap out all instances of cpu_set_t and replace them with virBitmap, > which some of the code was already using anyway. > > The changes are pretty mechanical, with one notable exception: an > assumption has been added on the max val

[libvirt] [PATCH 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-17 Thread Andrea Bolognani
Swap out all instances of cpu_set_t and replace them with virBitmap, which some of the code was already using anyway. The changes are pretty mechanical, with one notable exception: an assumption has been added on the max value we can run into while reading either socket_it or core_id. While this