Re: [libvirt] [PATCH 07/11] util: convert virIdentity class to use GObject

2019-09-30 Thread Pavel Hrdina
On Fri, Sep 27, 2019 at 06:17:29PM +0100, Daniel P. Berrangé wrote: > Converting from virObject to GObject is reasonably straightforward, > as illustrated by this patch for virIdentity > > In the header file > > - Remove > > typedef struct _virIdentity virIdentity > > - Add > >

Re: [libvirt] [PATCH 07/11] util: convert virIdentity class to use GObject

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 03:04:38PM +0200, Ján Tomko wrote: > On Fri, Sep 27, 2019 at 06:17:29PM +0100, Daniel P. Berrangé wrote: > > Converting from virObject to GObject is reasonably straightforward, > > as illustrated by this patch for virIdentity > > > > The change would be much easier to see

Re: [libvirt] [PATCH 07/11] util: convert virIdentity class to use GObject

2019-09-30 Thread Ján Tomko
On Fri, Sep 27, 2019 at 06:17:29PM +0100, Daniel P. Berrangé wrote: Converting from virObject to GObject is reasonably straightforward, as illustrated by this patch for virIdentity The change would be much easier to see if this patch did not contain the g_autofree changes and the removal of

[libvirt] [PATCH 07/11] util: convert virIdentity class to use GObject

2019-09-27 Thread Daniel P . Berrangé
Converting from virObject to GObject is reasonably straightforward, as illustrated by this patch for virIdentity In the header file - Remove typedef struct _virIdentity virIdentity - Add #define VIR_TYPE_IDENTITY virIdentity_get_type () G_DECLARE_FINAL_TYPE (virIdentity,