Re: [libvirt] [PATCH 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-22 Thread Laine Stump
On 12/20/2010 05:46 PM, Paweł Krześniak wrote: On Mon, Dec 20, 2010 at 09:03, Laine Stumpla...@laine.org wrote: brSetInetAddress can only set a single IP address on the bridge, and uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace it and brSetInetNetmask with a single

[libvirt] [PATCH 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-20 Thread Laine Stump
brSetInetAddress can only set a single IP address on the bridge, and uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace it and brSetInetNetmask with a single function that uses the external ip addr add command to add an address/prefix to the interface - this supports IPv6, and

Re: [libvirt] [PATCH 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-20 Thread Paweł Krześniak
On Mon, Dec 20, 2010 at 09:03, Laine Stump la...@laine.org wrote: brSetInetAddress can only set a single IP address on the bridge, and uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace it and brSetInetNetmask with a single function that uses the external ip addr add