Re: [libvirt] [PATCH 07/15] storage: Use VIR_AUTOFREE for storage backends

2019-02-11 Thread Erik Skultety
On Fri, Feb 08, 2019 at 10:06:07AM -0500, John Ferlan wrote: > [...] > > >> diff --git a/src/storage/storage_backend_iscsi_direct.c > >> b/src/storage/storage_backend_iscsi_direct.c > >> index 82fa4d7a25..6458b0f835 100644 > >> --- a/src/storage/storage_backend_iscsi_direct.c > >> +++ b/src/storag

Re: [libvirt] [PATCH 07/15] storage: Use VIR_AUTOFREE for storage backends

2019-02-08 Thread John Ferlan
[...] >> diff --git a/src/storage/storage_backend_iscsi_direct.c >> b/src/storage/storage_backend_iscsi_direct.c >> index 82fa4d7a25..6458b0f835 100644 >> --- a/src/storage/storage_backend_iscsi_direct.c >> +++ b/src/storage/storage_backend_iscsi_direct.c >> @@ -421,15 +421,14 @@ virISCSIDirectUp

Re: [libvirt] [PATCH 07/15] storage: Use VIR_AUTOFREE for storage backends

2019-02-07 Thread Erik Skultety
On Wed, Feb 06, 2019 at 08:41:39AM -0500, John Ferlan wrote: > Let's make use of the auto __cleanup capabilities. This also allows > for the cleanup of some goto paths. > > Signed-off-by: John Ferlan > --- > src/storage/storage_backend.c | 9 +-- > src/storage/storage_backend_disk.c

[libvirt] [PATCH 07/15] storage: Use VIR_AUTOFREE for storage backends

2019-02-06 Thread John Ferlan
Let's make use of the auto __cleanup capabilities. This also allows for the cleanup of some goto paths. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 9 +-- src/storage/storage_backend_disk.c | 62 +++--- src/storage/storage_backend_fs.c