Re: [libvirt] [PATCH 07/22] esx_vi_generator: Simplify get_occurrence_comment

2018-03-19 Thread Radostin Stoyanov
On 19/03/18 11:40, Marc Hartmayer wrote: > On Sat, Mar 17, 2018 at 03:23 PM +0100, Radostin Stoyanov > wrote: >> Reduce the number of if-statements and use a single return. >> Utilise a dictionary to map between occurrences and values. >> >> Signed-off-by: Radostin Stoyanov

Re: [libvirt] [PATCH 07/22] esx_vi_generator: Simplify get_occurrence_comment

2018-03-19 Thread Marc Hartmayer
On Sat, Mar 17, 2018 at 03:23 PM +0100, Radostin Stoyanov wrote: > Reduce the number of if-statements and use a single return. > Utilise a dictionary to map between occurrences and values. > > Signed-off-by: Radostin Stoyanov > --- >

Re: [libvirt] [PATCH 07/22] esx_vi_generator: Simplify get_occurrence_comment

2018-03-19 Thread Daniel P . Berrangé
On Sat, Mar 17, 2018 at 02:23:25PM +, Radostin Stoyanov wrote: > Reduce the number of if-statements and use a single return. > Utilise a dictionary to map between occurrences and values. > > Signed-off-by: Radostin Stoyanov > --- > src/esx/esx_vi_generator.py | 20

[libvirt] [PATCH 07/22] esx_vi_generator: Simplify get_occurrence_comment

2018-03-17 Thread Radostin Stoyanov
Reduce the number of if-statements and use a single return. Utilise a dictionary to map between occurrences and values. Signed-off-by: Radostin Stoyanov --- src/esx/esx_vi_generator.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git