Re: [libvirt] [PATCH 07/34] Convert monitor over to use virDomainDeviceAddress

2010-01-15 Thread Daniel Veillard
On Fri, Jan 08, 2010 at 05:23:03PM +, Daniel P. Berrange wrote: Convert the QEMU monitor APIs over to use virDomainDeviceAddress structs for passing addresses in/out, instead of individual bits. This makes the number of parameters smaller easier to deal with. No functional change *

Re: [libvirt] [PATCH 07/34] Convert monitor over to use virDomainDeviceAddress

2010-01-13 Thread Paolo Bonzini
On 01/08/2010 06:23 PM, Daniel P. Berrange wrote: @@ -1206,9 +1206,7 @@ int qemuMonitorJSONAddUSBDeviceMatch(qemuMonitorPtr mon, /* XXX qemu also returns a 'function' number now */ Wrong comment now. Paolo -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] [PATCH 07/34] Convert monitor over to use virDomainDeviceAddress

2010-01-08 Thread Daniel P. Berrange
Convert the QEMU monitor APIs over to use virDomainDeviceAddress structs for passing addresses in/out, instead of individual bits. This makes the number of parameters smaller easier to deal with. No functional change * src/qemu/qemu_driver.c, src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h,