Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

2015-10-14 Thread Peter Krempa
On Tue, Oct 13, 2015 at 15:11:01 -0400, John Ferlan wrote: > On 10/13/2015 08:50 AM, Peter Krempa wrote: > > On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: ... > > > > This might not work if the volume was created with different uid/gid as > > the process that is attempting to

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

2015-10-14 Thread John Ferlan
On 10/14/2015 08:21 AM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 15:11:01 -0400, John Ferlan wrote: >> On 10/13/2015 08:50 AM, Peter Krempa wrote: >>> On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: > > ... > >>> >>> This might not work if the volume was created with different

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

2015-10-13 Thread Peter Krempa
On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: > After a successful qemu-img/qcow-create of the backing file, if we > fail to stat the file, change it owner/group, or mode, then the > cleanup path should delete the file. > > Also moved the virCommandSetUID/virCommandSetGID inside the

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

2015-10-13 Thread John Ferlan
On 10/13/2015 08:50 AM, Peter Krempa wrote: > On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: >> After a successful qemu-img/qcow-create of the backing file, if we >> fail to stat the file, change it owner/group, or mode, then the >> cleanup path should delete the file. >> >> Also

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

2015-10-13 Thread John Ferlan
On 10/13/2015 03:11 PM, John Ferlan wrote: > > > On 10/13/2015 08:50 AM, Peter Krempa wrote: >> On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: >>> After a successful qemu-img/qcow-create of the backing file, if we >>> fail to stat the file, change it owner/group, or mode, then the

[libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

2015-10-09 Thread John Ferlan
After a successful qemu-img/qcow-create of the backing file, if we fail to stat the file, change it owner/group, or mode, then the cleanup path should delete the file. Also moved the virCommandSetUID/virCommandSetGID inside the condition used to actually run the command rather than randomly