Re: [libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-10-04 Thread Eric Blake
On 10/01/2010 09:01 AM, Daniel Veillard wrote: On Wed, Sep 29, 2010 at 06:02:12PM -0600, Eric Blake wrote: * src/conf/domain_conf.h (_virDomainDef): Adjust vcpus to unsigned short, to match virDomainGetInfo limit. Add maxvcpus member. [...] Two tightly-related changes. One:

Re: [libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-10-04 Thread Eric Blake
On 10/01/2010 09:01 AM, Daniel Veillard wrote: -if (virXPathULong(string(./vcpu[1]), ctxt,def-vcpus) 0) -def-vcpus = 1; +if (virXPathULong(string(./vcpu[1]), ctxt,count) 0) +def-maxvcpus = 1; +else { +def-maxvcpus = count; +if (def-maxvcpus != count

Re: [libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-10-01 Thread Daniel Veillard
On Wed, Sep 29, 2010 at 06:02:12PM -0600, Eric Blake wrote: * src/conf/domain_conf.h (_virDomainDef): Adjust vcpus to unsigned short, to match virDomainGetInfo limit. Add maxvcpus member. [...] Two tightly-related changes. One: virDomainGetInfo implicitly limits vcpus to a 16-bit number;

Re: [libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-10-01 Thread Daniel Veillard
On Thu, Sep 30, 2010 at 01:27:27PM -0600, Eric Blake wrote: [self-review] On 09/29/2010 06:02 PM, Eric Blake wrote: Two tightly-related changes. One: virDomainGetInfo implicitly limits vcpus to a 16-bit number; so there's no need to pretend otherwise through the rest of the code. Two:

Re: [libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-09-30 Thread Eric Blake
[self-review] On 09/29/2010 06:02 PM, Eric Blake wrote: Two tightly-related changes. One: virDomainGetInfo implicitly limits vcpus to a 16-bit number; so there's no need to pretend otherwise through the rest of the code. Two: add a new maxvcpus member, but for now, ensure that all domains

[libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-09-29 Thread Eric Blake
* src/conf/domain_conf.h (_virDomainDef): Adjust vcpus to unsigned short, to match virDomainGetInfo limit. Add maxvcpus member. * src/conf/domain_conf.c (virDomainDefParseXML) (virDomainDefFormat): parse and print out vcpu details. * src/xen/xend_internal.c (xenDaemonParseSxpr)