Re: [libvirt] [PATCH 08/16] snapshot: Access snapshot def directly when needed

2019-03-23 Thread Eric Blake
On 3/20/19 12:40 AM, Eric Blake wrote: > An upcoming patch will rework virDomainSnapshotObjList to be generic > for both snapshots and checkpoints; reduce the churn by adding a new > accessor virDomainSnapshotObjGetDef() which returns the > snapshot-specific definition even when the list is

Re: [libvirt] [PATCH 08/16] snapshot: Access snapshot def directly when needed

2019-03-21 Thread Eric Blake
On 3/20/19 4:37 PM, John Ferlan wrote: > > > On 3/20/19 1:40 AM, Eric Blake wrote: >> An upcoming patch will rework virDomainSnapshotObjList to be generic >> for both snapshots and checkpoints; reduce the churn by adding a new >> accessor virDomainSnapshotObjGetDef() which returns the >>

Re: [libvirt] [PATCH 08/16] snapshot: Access snapshot def directly when needed

2019-03-20 Thread John Ferlan
On 3/20/19 1:40 AM, Eric Blake wrote: > An upcoming patch will rework virDomainSnapshotObjList to be generic > for both snapshots and checkpoints; reduce the churn by adding a new > accessor virDomainSnapshotObjGetDef() which returns the > snapshot-specific definition even when the list is

[libvirt] [PATCH 08/16] snapshot: Access snapshot def directly when needed

2019-03-19 Thread Eric Blake
An upcoming patch will rework virDomainSnapshotObjList to be generic for both snapshots and checkpoints; reduce the churn by adding a new accessor virDomainSnapshotObjGetDef() which returns the snapshot-specific definition even when the list is rewritten to operate only on a base class, then using