>>> +if (ret == VIR_CPU_COMPARE_ERROR)
>>> +goto error;
>>
>> Admittedly I did not look too closely, but will the compareHypervisorCPU
>> functions actually
>> return "VIR_CPU_COMPARE_ERROR" on error? If so, wouldn't it be more sensible
>> to return a
>> "VIR_HYPERVISOR_CPU_C
On Wed, May 16, 2018 at 10:39:27AM +0200, Jiri Denemark wrote:
This new API compares the given CPU description with the CPU the
specified hypervisor is able to provide on the host. It is a more useful
version of virConnectCompareCPU, which compares the CPU definition with
the host CPU without con
On Tue, May 22, 2018 at 18:27:51 -0400, Collin Walling wrote:
> On 05/16/2018 04:39 AM, Jiri Denemark wrote:
> > This new API compares the given CPU description with the CPU the
> > specified hypervisor is able to provide on the host. It is a more useful
> > version of virConnectCompareCPU, which c
On 05/16/2018 04:39 AM, Jiri Denemark wrote:
> This new API compares the given CPU description with the CPU the
> specified hypervisor is able to provide on the host. It is a more useful
> version of virConnectCompareCPU, which compares the CPU definition with
> the host CPU without considering any
This new API compares the given CPU description with the CPU the
specified hypervisor is able to provide on the host. It is a more useful
version of virConnectCompareCPU, which compares the CPU definition with
the host CPU without considering any specific hypervisor and its
abilities.
Signed-off-b