Re: [libvirt] [PATCH 09/10] storage: open secret driver connection at time of use

2018-01-31 Thread Daniel P . Berrangé
On Mon, Jan 29, 2018 at 07:44:18AM +0100, Michal Privoznik wrote: > On 01/26/2018 02:35 PM, Daniel P. Berrangé wrote: > > Instead of passing around a virConnectPtr object, just open a connection > > to the secret driver at time of use. Opening connections on demand will > > be beneficial when the s

Re: [libvirt] [PATCH 09/10] storage: open secret driver connection at time of use

2018-01-29 Thread Peter Krempa
On Fri, Jan 26, 2018 at 13:35:36 +, Daniel Berrange wrote: > Instead of passing around a virConnectPtr object, just open a connection > to the secret driver at time of use. Opening connections on demand will > be beneficial when the secret driver is in a separate daemon. It also > solves the pr

Re: [libvirt] [PATCH 09/10] storage: open secret driver connection at time of use

2018-01-28 Thread Michal Privoznik
On 01/26/2018 02:35 PM, Daniel P. Berrangé wrote: > Instead of passing around a virConnectPtr object, just open a connection > to the secret driver at time of use. Opening connections on demand will > be beneficial when the secret driver is in a separate daemon. It also > solves the problem that a

[libvirt] [PATCH 09/10] storage: open secret driver connection at time of use

2018-01-26 Thread Daniel P . Berrangé
Instead of passing around a virConnectPtr object, just open a connection to the secret driver at time of use. Opening connections on demand will be beneficial when the secret driver is in a separate daemon. It also solves the problem that a number of callers just pass in a NULL connection today whi