Re: [libvirt] [PATCH 09/10] vbox: factor a large function

2010-08-19 Thread Matthias Bolte
2010/8/19 Eric Blake ebl...@redhat.com: * src/vbox/vbox_tmpl.c (vboxDomainCreateWithFlags): Split... (vboxStartMachine): ...into new helper. --- This function was just too unbearable with that much nested indentation. This should be a no-op refactoring. Looks fine and I can still start a

Re: [libvirt] [PATCH 09/10] vbox: factor a large function

2010-08-19 Thread Eric Blake
On 08/19/2010 03:44 PM, Matthias Bolte wrote: 2010/8/19 Eric Blake ebl...@redhat.com: * src/vbox/vbox_tmpl.c (vboxDomainCreateWithFlags): Split... (vboxStartMachine): ...into new helper. --- This function was just too unbearable with that much nested indentation. This should be a no-op

[libvirt] [PATCH 09/10] vbox: factor a large function

2010-08-18 Thread Eric Blake
* src/vbox/vbox_tmpl.c (vboxDomainCreateWithFlags): Split... (vboxStartMachine): ...into new helper. --- This function was just too unbearable with that much nested indentation. This should be a no-op refactoring. vboxDomainDefineXML is even worse, and contains the remaining sprintf instances in