On Tue, 2018-02-13 at 09:34 -0500, John Ferlan wrote:
> On 02/13/2018 08:46 AM, Andrea Bolognani wrote:
> > [...] Should I
> > send out a v2, or should I just go ahead and push the series given
> > the minor nature of the adjustments?
>
> I see no need for a v2 since the adjustments were essential
On 02/13/2018 08:46 AM, Andrea Bolognani wrote:
> On Tue, 2018-02-13 at 07:22 -0500, John Ferlan wrote:
>>> Another approach, which didn't make it to the list for some reason,
>>> was to end the comment with
>>>
>>> [...] and so on. See virDomainDefFeaturesCheckABIStability() for
>>> more det
On Tue, 2018-02-13 at 07:22 -0500, John Ferlan wrote:
> > Another approach, which didn't make it to the list for some reason,
> > was to end the comment with
> >
> > [...] and so on. See virDomainDefFeaturesCheckABIStability() for
> > more details.
> >
> > That seems like a better way to hand
On 02/13/2018 04:40 AM, Andrea Bolognani wrote:
> On Mon, 2018-02-12 at 16:59 -0500, John Ferlan wrote:
>>> @@ -19224,14 +19224,13 @@ virDomainDefParseXML(xmlDocPtr xml,
>>> tmp = virXMLPropString(nodes[i], "driver");
>>> if (tmp) {
>>> int value = virDo
On Mon, 2018-02-12 at 16:59 -0500, John Ferlan wrote:
> > @@ -19224,14 +19224,13 @@ virDomainDefParseXML(xmlDocPtr xml,
> > tmp = virXMLPropString(nodes[i], "driver");
> > if (tmp) {
> > int value = virDomainIOAPICTypeFromString(tmp);
> > -
On 02/06/2018 11:42 AM, Andrea Bolognani wrote:
> Instead of storing separately whether the feature is enabled
> or not and what driver should be used, store both of them in
> a single place.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/conf/domain_conf.c | 29 +
Instead of storing separately whether the feature is enabled
or not and what driver should be used, store both of them in
a single place.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 29 +
src/conf/domain_conf.h | 11 ++-
src/qemu/qemu_comman
