Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-11 Thread Daniel Veillard
On Wed, Jun 10, 2009 at 04:20:08PM -0400, Dave Allan wrote: > Daniel P. Berrange wrote: >> On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote: >>> --- >>> src/node_device_conf.c |5 + >>> src/node_device_conf.h |1 + >>> src/node_device_hal.c |1 + >>> 3 files changed, 7

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-10 Thread Dave Allan
Daniel P. Berrange wrote: On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote: --- src/node_device_conf.c |5 + src/node_device_conf.h |1 + src/node_device_hal.c |1 + 3 files changed, 7 insertions(+), 0 deletions(-) ACK, patch looks pretty trivial & fine. Could you

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-08 Thread Daniel P. Berrange
On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote: > --- > src/node_device_conf.c |5 + > src/node_device_conf.h |1 + > src/node_device_hal.c |1 + > 3 files changed, 7 insertions(+), 0 deletions(-) ACK, patch looks pretty trivial & fine. Could you also extend the docs

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-08 Thread Daniel P. Berrange
On Mon, Jun 08, 2009 at 02:55:02PM -0400, Dave Allan wrote: > Daniel Veillard wrote: > >On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote: > >>--- > >> src/node_device_conf.c |5 + > >> src/node_device_conf.h |1 + > >> src/node_device_hal.c |1 + > >> 3 files changed, 7 ins

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-08 Thread Dave Allan
Daniel Veillard wrote: On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote: --- src/node_device_conf.c |5 + src/node_device_conf.h |1 + src/node_device_hal.c |1 + 3 files changed, 7 insertions(+), 0 deletions(-) Patch looks fine to me, my main question is if we c

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-08 Thread Daniel Veillard
On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote: > --- > src/node_device_conf.c |5 + > src/node_device_conf.h |1 + > src/node_device_hal.c |1 + > 3 files changed, 7 insertions(+), 0 deletions(-) Patch looks fine to me, my main question is if we can get the same t

[libvirt] [PATCH 1/1] Add support for serial number in HAL storage

2009-06-08 Thread David Allan
--- src/node_device_conf.c |5 + src/node_device_conf.h |1 + src/node_device_hal.c |1 + 3 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/node_device_conf.c b/src/node_device_conf.c index 2360427..e37295a 100644 --- a/src/node_device_conf.c +++ b/src/node_device