Re: [libvirt] [PATCH 1/1] Remove contiguous CPU indexes assumption

2013-02-28 Thread Li Zhang
On 2013年02月28日 14:27, Li Zhang wrote: On 2013年02月28日 07:13, Eric Blake wrote: On 02/27/2013 05:13 AM, Li Zhang wrote: Hi Eric, This should belong to bug-fix, could it be pushed to 1.0.3? Without any test case under 'make check' that exposes the failure, I'm a bit worried that this might

Re: [libvirt] [PATCH 1/1] Remove contiguous CPU indexes assumption

2013-02-27 Thread Li Zhang
Hi Eric, This should belong to bug-fix, could it be pushed to 1.0.3? Thanks. On Wed, Feb 27, 2013 at 11:18 AM, Li Zhang zhlci...@gmail.com wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64

Re: [libvirt] [PATCH 1/1] Remove contiguous CPU indexes assumption

2013-02-27 Thread Li Zhang
On 2013年02月28日 07:13, Eric Blake wrote: On 02/27/2013 05:13 AM, Li Zhang wrote: Hi Eric, This should belong to bug-fix, could it be pushed to 1.0.3? Without any test case under 'make check' that exposes the failure, I'm a bit worried that this might cause regressions on other setups. I'm not

[libvirt] [PATCH 1/1] Remove contiguous CPU indexes assumption

2013-02-26 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT is needed to be disabled, so CPU information is not right on ppc64 and vpuinfo, vcpupin can't work