Re: [libvirt] [PATCH 1/1] Support for rdp/desktop types in graphics tag

2009-05-15 Thread Daniel Veillard
On Thu, Apr 30, 2009 at 04:15:27PM +0200, Pritesh Kothari wrote: Hi All, As per the discussion earlier on the list I have modified the rdp type and added a new desktop type and posting the patch for same. Okay, this looks fine, but we also need a description of the format extensions in

[libvirt] [PATCH 1/1] Support for rdp/desktop types in graphics tag

2009-04-30 Thread Pritesh Kothari
Hi All, As per the discussion earlier on the list I have modified the rdp type and added a new desktop type and posting the patch for same. Regards, Pritesh diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 2f784e1..5e4aa5b 100644 --- a/docs/schemas/domain.rng +++

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-24 Thread Pritesh Kothari
true. no need for that. Actually I believe there is. I think what was originally meant was whether the domain would be able to do real accelerated 3D using the host hardware, from the guest. VBox provides an option to make 3D calls on the virtualized video card call the real 3D api of the

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-24 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 09:35:20PM +0200, Florian Vichot wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Isn't 3D support implied by the type of graphics card emulated ? eg cirrus is a 2d only card, so it seems like 3Daccel is redundant. Similarly if the graphics model were a 3d

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 16, 2009 at 11:21:23AM +0200, Pritesh Kothari wrote: Hi All, I have added support for RDP. So, summarizing your suggested XML syntax, it more or less looked like this: graphics type='rdp' port='12345' listen='172.21.4.3' autoport='no' headless='yes'

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, graphics type='desktop'/ graphics type='rdp' port='1234' autoport='no' listen='172.21.4.3'/ this seems ok, but the only question I have is, currently libvirt supports only one virDomainGraphicsDef, so is it ok for me add support for more then one virDomainGraphicsDef? or else

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 01:32:24PM +0200, Pritesh Kothari wrote: Hi Daniel, graphics type='desktop'/ graphics type='rdp' port='1234' autoport='no' listen='172.21.4.3'/ this seems ok, but the only question I have is, currently libvirt supports only one virDomainGraphicsDef, so is it

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 01:32:24PM +0200, Pritesh Kothari wrote: Hi Daniel, graphics type='desktop'/ graphics type='rdp' port='1234' autoport='no' listen='172.21.4.3'/ this seems ok, but the only question I have is, currently libvirt supports only one virDomainGraphicsDef, so is it

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, yes this is a limitation of the impelentation, not of the model, it makes more sense to allow multiple graphis entries. Ok, will do this. feedback about attributes (auth='external' authtimeout='1234') would also be appreciated. Thanks. auth='external' sounds unclear,

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, We don't currently have any explicit representation of a video card device. The graphics tag is really representing the host I/O layer, covering video, mouse, keyboard (and potentially audio too). I didn't get you here? i mean there is a seperate virDomainSoundDefPtr,

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: Hi Daniel, We don't currently have any explicit representation of a video card device. The graphics tag is really representing the host I/O layer, covering video, mouse, keyboard (and potentially audio too). I didn't

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Gerd Hoffmann
On 04/23/09 12:43, Daniel P. Berrange wrote: Historically with Xen and QEMU there has only been ability to have either SDL graphics, or VNC graphics, but not both. Note that this has changed recently, qemu can handle both vnc and sdl now. graphics type='desktop'/ graphics type='rdp'

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 01:47:17PM +0100, Daniel P. Berrange wrote: On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: I think we need to add an explicit tag to represent video devices real soon. At very least we need to be able to indicate the type of video card - QEMU

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
On Thursday 23 April 2009 14:47:17 Daniel P. Berrange wrote: On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: Hi Daniel, We don't currently have any explicit representation of a video card device. The graphics tag is really representing the host I/O layer, covering

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 02:56:46PM +0200, Daniel Veillard wrote: On Thu, Apr 23, 2009 at 01:47:17PM +0100, Daniel P. Berrange wrote: On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: I think we need to add an explicit tag to represent video devices real soon. At very

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 02:13:18PM +0100, Daniel P. Berrange wrote: On Thu, Apr 23, 2009 at 02:56:46PM +0200, Daniel Veillard wrote: On Thu, Apr 23, 2009 at 01:47:17PM +0100, Daniel P. Berrange wrote: On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: I think we need to

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Florian Vichot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Isn't 3D support implied by the type of graphics card emulated ? eg cirrus is a 2d only card, so it seems like 3Daccel is redundant. Similarly if the graphics model were a 3d card. true. no need for that. Actually I believe there is. I think