Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-28 Thread Nikolay Shirokovskiy
On 28.11.2019 14:11, Peter Krempa wrote: > On Thu, Nov 28, 2019 at 10:51:56 +, Nikolay Shirokovskiy wrote: >> >> >> On 28.11.2019 12:05, Peter Krempa wrote: >>> On Thu, Nov 28, 2019 at 07:29:08 +, Nikolay Shirokovskiy wrote: On 27.11.2019 17:56, Peter Krempa wrote: > O

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-28 Thread Peter Krempa
On Thu, Nov 28, 2019 at 10:51:56 +, Nikolay Shirokovskiy wrote: > > > On 28.11.2019 12:05, Peter Krempa wrote: > > On Thu, Nov 28, 2019 at 07:29:08 +, Nikolay Shirokovskiy wrote: > >> > >> > >> On 27.11.2019 17:56, Peter Krempa wrote: > >>> On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-28 Thread Nikolay Shirokovskiy
On 28.11.2019 12:05, Peter Krempa wrote: > On Thu, Nov 28, 2019 at 07:29:08 +, Nikolay Shirokovskiy wrote: >> >> >> On 27.11.2019 17:56, Peter Krempa wrote: >>> On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay Shirokovskiy wrote: Due to race qemuDomainGetBlockJobInfo can return there is

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-28 Thread Peter Krempa
On Thu, Nov 28, 2019 at 07:29:08 +, Nikolay Shirokovskiy wrote: > > > On 27.11.2019 17:56, Peter Krempa wrote: > > On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay Shirokovskiy wrote: > >> Due to race qemuDomainGetBlockJobInfo can return there is > >> no block job for disk but later call to sp

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-27 Thread Nikolay Shirokovskiy
On 27.11.2019 17:56, Peter Krempa wrote: > On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay Shirokovskiy wrote: >> Due to race qemuDomainGetBlockJobInfo can return there is >> no block job for disk but later call to spawn new blockjob >> can fail because libvirt internally still not process block

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-27 Thread Peter Krempa
On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay Shirokovskiy wrote: > Due to race qemuDomainGetBlockJobInfo can return there is > no block job for disk but later call to spawn new blockjob > can fail because libvirt internally still not process blockjob > finishing. Thus let's wait for blockjob fin

[libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-27 Thread Nikolay Shirokovskiy
Due to race qemuDomainGetBlockJobInfo can return there is no block job for disk but later call to spawn new blockjob can fail because libvirt internally still not process blockjob finishing. Thus let's wait for blockjob finishing if we report there is no more blockjob. Signed-off-by: Nikolay Shiro