Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2014-01-08 Thread Pradipta Kumar Banerjee
ping. On 12/19/2013 10:10 AM, Pradipta Kr. Banerjee wrote: > From: "Pradipta Kr. Banerjee" > > virsh nodecpustats erroneously returns stats for offline cpus on Linux > > To retrieve node cpu statistics on Linux system, the > linuxNodeGetCPUstats function performs a minimal match of the input >

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-20 Thread Bing Bu Cao
On 12/20/2013 05:47 PM, Pradipta Kumar Banerjee wrote: [snip] for (i = 0; i < *nparams; i++) { virNodeCPUStatsPtr param = ¶ms[i]; What about this? diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 1838547..aa1ad81 100644 --- a/src/nodeinfo.c +++ b/src/nodein

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-20 Thread Pradipta Kumar Banerjee
[snip] >>> for (i = 0; i < *nparams; i++) { >>> virNodeCPUStatsPtr param = ¶ms[i]; >> >> What about this? >> >> diff --git a/src/nodeinfo.c b/src/nodeinfo.c >> index 1838547..aa1ad81 100644 >> --- a/src/nodeinfo.c >> +++ b/src/nodeinfo.c >> @@ -637,8 +637,9 @@ linuxN

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-19 Thread Bing Bu Cao
On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote: From: "Pradipta Kr. Banerjee" virsh nodecpustats erroneously returns stats for offline cpus on Linux To retrieve node cpu statistics on Linux system, the linuxNodeGetCPUstats function performs a minimal match of the input cpuid with the cpui

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-19 Thread Pradipta Kumar Banerjee
On 12/19/2013 02:02 PM, Bing Bu Cao wrote: > On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote: >> From: "Pradipta Kr. Banerjee" >> >> virsh nodecpustats erroneously returns stats for offline cpus on Linux >> >> To retrieve node cpu statistics on Linux system, the >> linuxNodeGetCPUstats functio

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-19 Thread Bing Bu Cao
On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote: From: "Pradipta Kr. Banerjee" virsh nodecpustats erroneously returns stats for offline cpus on Linux To retrieve node cpu statistics on Linux system, the linuxNodeGetCPUstats function performs a minimal match of the input cpuid with the cpui

[libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-18 Thread Pradipta Kr. Banerjee
From: "Pradipta Kr. Banerjee" virsh nodecpustats erroneously returns stats for offline cpus on Linux To retrieve node cpu statistics on Linux system, the linuxNodeGetCPUstats function performs a minimal match of the input cpuid with the cpuid read from /proc/cpustat. On systems with larger cpus