Re: [libvirt] [PATCH 1/13] Adding recursive locks

2010-03-17 Thread Daniel P. Berrange
On Thu, Mar 11, 2010 at 08:06:34AM -0500, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML are prevented but their detection requires

Re: [libvirt] [PATCH 1/13] Adding recursive locks

2010-03-17 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 07:48:46 AM: Berrange void virMutexDestroy(virMutexPtr m) { pthread_mutex_destroy(m-lock); Minor point, I think it would be better to call it virMutexInitRecursive() so we keep the standard virMutex prefix for naming

[libvirt] [PATCH 1/13] Adding recursive locks

2010-03-11 Thread Stefan Berger
This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML are prevented but their detection requires recursive locks. --- src/util/threads-pthread.c | 12