Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-27 Thread Ruben S. Montero
Hi Daniel, Right now most of us are out of the office, so we will be able to send the patches by next week. Sorry for this delay :( Ruben On Wed, May 27, 2009 at 10:45 AM, Daniel Veillard wrote: > On Tue, May 26, 2009 at 04:26:36PM +0200, Ruben S. Montero wrote: >> Hi, >> >> Probably the easies

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-27 Thread Daniel Veillard
On Tue, May 26, 2009 at 04:26:36PM +0200, Ruben S. Montero wrote: > Hi, > > Probably the easiest way to solve this is to get rid to of the > OpenNebula client library. So we do not have the license issue and, as > Daniel said, we do not have to include the C++ dependencies. > > We'll try to send

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-26 Thread Ruben S. Montero
Hi, Probably the easiest way to solve this is to get rid to of the OpenNebula client library. So we do not have the license issue and, as Daniel said, we do not have to include the C++ dependencies. We'll try to send the patch ASAP. Regards Ruben On Tue, May 26, 2009 at 3:16 PM, Daniel P. Ber

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-26 Thread Daniel P. Berrange
On Tue, May 26, 2009 at 11:23:27AM +0100, Daniel P. Berrange wrote: > On Mon, May 25, 2009 at 06:01:06PM +0200, Ruben S. Montero wrote: > > So, if finally there is some kind of incompatibility with OpenNebula > > using Apache2, we have a couple of options: > > > > 1- use the conditional compilatio

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-26 Thread Daniel P. Berrange
On Mon, May 25, 2009 at 06:01:06PM +0200, Ruben S. Montero wrote: > Hi Daniel, > > First, thank you very much for improving the OpenNebula driver with > your comments. I am totally agree with you suggestion about the > configure.in, it should be a quick fix. > > Regarding the licenses, I do not r

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-26 Thread Daniel P. Berrange
On Mon, May 25, 2009 at 02:08:53PM +0200, Daniel Veillard wrote: > On Wed, May 20, 2009 at 04:07:12PM +0200, "Abel Míguez Rodríguez" wrote: > > > > > On Wed, May 20, 2009 at 11:32:18AM +0100, Daniel P. Berrange wrote: > [...] > > > > > Here is the One driver & patches for the current git's > [...

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-26 Thread Daniel Veillard
On Mon, May 25, 2009 at 06:01:06PM +0200, Ruben S. Montero wrote: > Hi Daniel, > > First, thank you very much for improving the OpenNebula driver with > your comments. I am totally agree with you suggestion about the > configure.in, it should be a quick fix. Okay :-) > Regarding the licenses,

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-25 Thread Ruben S. Montero
Hi Daniel, First, thank you very much for improving the OpenNebula driver with your comments. I am totally agree with you suggestion about the configure.in, it should be a quick fix. Regarding the licenses, I do not really see the problem. I mean, you can link with GPL and Apache as libvirt is us

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-25 Thread Daniel Veillard
On Wed, May 20, 2009 at 04:07:12PM +0200, "Abel Míguez Rodríguez" wrote: > > > On Wed, May 20, 2009 at 11:32:18AM +0100, Daniel P. Berrange wrote: [...] > > > > Here is the One driver & patches for the current git's [...] > > > My inclination at this point is to merge the driver and then > > we

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-20 Thread Abel Míguez Rodríguez
> On Wed, May 20, 2009 at 11:32:18AM +0100, Daniel P. Berrange wrote: > > On Wed, Apr 22, 2009 at 05:03:41PM +0200, "Abel M?guez > Rodr?guez" wrote: > > > Hi all, > > > > > > Here is the One driver & patches for the current git's > master commit "9e9527 - Remove stale QEMU pidfiles". > > > > >

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-20 Thread Daniel Veillard
On Wed, May 20, 2009 at 11:32:18AM +0100, Daniel P. Berrange wrote: > On Wed, Apr 22, 2009 at 05:03:41PM +0200, "Abel M?guez Rodr?guez" wrote: > > Hi all, > > > > Here is the One driver & patches for the current git's master commit > > "9e9527 - Remove stale QEMU pidfiles". > > > > [PATCH 1/2] P

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-05-20 Thread Daniel P. Berrange
On Wed, Apr 22, 2009 at 05:03:41PM +0200, "Abel M?guez Rodr?guez" wrote: > Hi all, > > Here is the One driver & patches for the current git's master commit "9e9527 > - Remove stale QEMU pidfiles". > > [PATCH 1/2] Patch to be applied to libvirt-0.6.2 sources and building files. > [PATCH 2/2] Driv

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Abel Míguez Rodríguez
> > domain) { break; > case VIR_FROM_VBOX: >  dom = "VBOX "; > +    case VIR_FROM_ONE: > +    dom = "ONE "; > >    break; > >  } > >  return(dom); > > there is break missing here. will cause subtle errors if not failures. You are right, a mistake

[libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Abel Míguez Rodríguez
Hi all, Here is the One driver & patches for the current git's master commit "9e9527 - Remove stale QEMU pidfiles". [PATCH 1/2] Patch to be applied to libvirt-0.6.2 sources and building files. [PATCH 2/2] Driver source code. Thanks for all the comments about the patches. We waited for the libvi

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Pritesh Kothari
Hi Abel >- Included driver's files in a different directory "src/opennebula" Great, wouldn't crowd the src/ directory anymore, thanks. > domain) { break; > case VIR_FROM_VBOX: > dom = "VBOX "; > +case VIR_FROM_ONE: > +dom = "ONE "; > break;