Re: [libvirt] [PATCH 1/2] Don't include Makefile.ci in Makefile.am

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 03:56:20PM +0200, Martin Kletzander wrote: > On Thu, May 09, 2019 at 01:54:42PM +0100, Daniel P. Berrangé wrote: > > On Tue, May 07, 2019 at 05:45:30PM +0200, Martin Kletzander wrote: > > > The way it works now the Makefile needs to be both make valid and automake > > > vali

Re: [libvirt] [PATCH 1/2] Don't include Makefile.ci in Makefile.am

2019-05-09 Thread Martin Kletzander
On Thu, May 09, 2019 at 01:54:42PM +0100, Daniel P. Berrangé wrote: On Tue, May 07, 2019 at 05:45:30PM +0200, Martin Kletzander wrote: The way it works now the Makefile needs to be both make valid and automake valid. That is fine for now, but if we want to use anything more advanced, like condi

Re: [libvirt] [PATCH 1/2] Don't include Makefile.ci in Makefile.am

2019-05-09 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 05:45:30PM +0200, Martin Kletzander wrote: > The way it works now the Makefile needs to be both make valid and automake > valid. That is fine for now, but if we want to use anything more advanced, > like > conditionals, we cannot have it like that any more. > > So instead

[libvirt] [PATCH 1/2] Don't include Makefile.ci in Makefile.am

2019-05-07 Thread Martin Kletzander
The way it works now the Makefile needs to be both make valid and automake valid. That is fine for now, but if we want to use anything more advanced, like conditionals, we cannot have it like that any more. So instead forward all ci-* rules to that file. Signed-off-by: Martin Kletzander --- Ma