Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-27 Thread Michal Privoznik
On 24.06.2011 07:19, Daniel Veillard wrote: > On Wed, Jun 22, 2011 at 11:26:27AM -0600, Eric Blake wrote: >> On 06/22/2011 11:05 AM, Jiri Denemark wrote: >>> On Wed, Jun 22, 2011 at 16:47:18 +0100, Daniel P. Berrange wrote: If the QEMU process has been stopped (kill -STOP/gdb), or the QEM

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-27 Thread Eric Blake
On 06/22/2011 09:47 AM, Daniel P. Berrange wrote: > If the QEMU process has been stopped (kill -STOP/gdb), or the > QEMU process has live-locked itself, then we will never get a > reply from the monitor. We should not wait forever in this > case, but instead timeout after a reasonable amount of tim

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-23 Thread Daniel Veillard
On Wed, Jun 22, 2011 at 07:05:08PM +0200, Jiri Denemark wrote: > On Wed, Jun 22, 2011 at 16:47:18 +0100, Daniel P. Berrange wrote: > > If the QEMU process has been stopped (kill -STOP/gdb), or the > > QEMU process has live-locked itself, then we will never get a > > reply from the monitor. We shoul

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-23 Thread Daniel Veillard
On Wed, Jun 22, 2011 at 11:26:27AM -0600, Eric Blake wrote: > On 06/22/2011 11:05 AM, Jiri Denemark wrote: > > On Wed, Jun 22, 2011 at 16:47:18 +0100, Daniel P. Berrange wrote: > >> If the QEMU process has been stopped (kill -STOP/gdb), or the > >> QEMU process has live-locked itself, then we will

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-22 Thread Eric Blake
On 06/22/2011 11:05 AM, Jiri Denemark wrote: > On Wed, Jun 22, 2011 at 16:47:18 +0100, Daniel P. Berrange wrote: >> If the QEMU process has been stopped (kill -STOP/gdb), or the >> QEMU process has live-locked itself, then we will never get a >> reply from the monitor. We should not wait forever in

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-22 Thread Jiri Denemark
On Wed, Jun 22, 2011 at 16:47:18 +0100, Daniel P. Berrange wrote: > If the QEMU process has been stopped (kill -STOP/gdb), or the > QEMU process has live-locked itself, then we will never get a > reply from the monitor. We should not wait forever in this > case, but instead timeout after a reasonab

[libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-22 Thread Daniel P. Berrange
If the QEMU process has been stopped (kill -STOP/gdb), or the QEMU process has live-locked itself, then we will never get a reply from the monitor. We should not wait forever in this case, but instead timeout after a reasonable amount of time. NB if the host has high CPU load, or a single monitor