Re: [libvirt] [PATCH 1/2] build: don't use test cond1 -o cond2: it's not portable

2010-03-25 Thread Jim Meyering
Eric Blake wrote: * configure.ac: Use test cond1 || test cond2 instead. * m4/compiler-flags.m4 (gl_COMPILER_FLAGS): Likewise. * tests/test-lib.sh (verbose): Likewise. --- Is it worth reformatting any of the lines that now exceed 80 columns? I debated the same thing and ended up splitting one

[libvirt] [PATCH 1/2] build: don't use test cond1 -o cond2: it's not portable

2010-03-24 Thread Eric Blake
* configure.ac: Use test cond1 || test cond2 instead. * m4/compiler-flags.m4 (gl_COMPILER_FLAGS): Likewise. * tests/test-lib.sh (verbose): Likewise. --- I guess this serves as an implicit ACK to the fact that you accidentally pushed your patches along the same lines. Is it worth reformatting any