Re: [libvirt] [PATCH 1/2] conf: Rename VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI

2019-03-05 Thread Ján Tomko
On Tue, Mar 05, 2019 at 04:07:39PM +0100, Andrea Bolognani wrote: While the string associated with the enum value is virtio-scsi, having the string "SCSI" show up twice in the name of the enum value is unnecessary and needlessly deviates from the by now It is not needless, it is for

[libvirt] [PATCH 1/2] conf: Rename VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI

2019-03-05 Thread Andrea Bolognani
While the string associated with the enum value is virtio-scsi, having the string "SCSI" show up twice in the name of the enum value is unnecessary and needlessly deviates from the by now well established practice of having MODEL_(VIRTIO|VIRTIO_TRANSITIONAL|VIRTIO_NON_TRANSITIONAL) enum values