Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-09-04 Thread Viktor Mihajlovski
On 08/31/2012 03:33 PM, Viktor Mihajlovski wrote: On 08/30/2012 07:37 PM, Daniel P. Berrange wrote: How about using this: blockio logical_size='512' physical_size='4096'/ Regards, Daniel That is perfectly fine with me. Any other suggestions for a v2 patch? Hi Daniel, since the

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-09-04 Thread Daniel P. Berrange
On Tue, Sep 04, 2012 at 01:57:00PM +0200, Viktor Mihajlovski wrote: On 08/31/2012 03:33 PM, Viktor Mihajlovski wrote: On 08/30/2012 07:37 PM, Daniel P. Berrange wrote: How about using this: blockio logical_size='512' physical_size='4096'/ Regards, Daniel That is perfectly fine

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-31 Thread Viktor Mihajlovski
On 08/30/2012 07:37 PM, Daniel P. Berrange wrote: How about using this: blockio logical_size='512' physical_size='4096'/ Regards, Daniel That is perfectly fine with me. Any other suggestions for a v2 patch? -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-31 Thread Eric Blake
On 08/29/2012 08:48 AM, Viktor Mihajlovski wrote: Introducing a new iolimits element allowing to override certain properties of a guest block device like the physical and logical block size. This can be useful for platforms with 'non-standard' disk formats like S390 DASD with its 4K block

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-30 Thread Viktor Mihajlovski
On 08/29/2012 07:08 PM, Daniel P. Berrange wrote: lt;geometry cyls='16383' heads='16' secs='63' trans='lba'/gt; + lt;iolimits logical_block_size='512' physical_block_size='4096'/gt; I don't think 'iolimits' is a very good name for this - it suggested to me that it was doing I/o

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-30 Thread Daniel P. Berrange
On Thu, Aug 30, 2012 at 10:16:45AM +0200, Viktor Mihajlovski wrote: On 08/29/2012 07:08 PM, Daniel P. Berrange wrote: lt;geometry cyls='16383' heads='16' secs='63' trans='lba'/gt; + lt;iolimits logical_block_size='512' physical_block_size='4096'/gt; I don't think 'iolimits' is a

[libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-29 Thread Viktor Mihajlovski
Introducing a new iolimits element allowing to override certain properties of a guest block device like the physical and logical block size. This can be useful for platforms with 'non-standard' disk formats like S390 DASD with its 4K block size. Signed-off-by: Viktor Mihajlovski

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-29 Thread Daniel P. Berrange
On Wed, Aug 29, 2012 at 05:48:30PM +0200, Viktor Mihajlovski wrote: Introducing a new iolimits element allowing to override certain properties of a guest block device like the physical and logical block size. This can be useful for platforms with 'non-standard' disk formats like S390 DASD