[libvirt] [PATCH 1/2] conf: only accept capabilities mode hostdev in LXC.

2014-06-19 Thread Jincheng Miao
hostdev has mode capabilities for LXC, from formatdomain.html: Block / character devices from the host can be passed through to the guest using the hostdev element. This is only possible with container based virtualization. since after 1.0.1 for LXC So forbid capabilities mode hostdev if domain

Re: [libvirt] [PATCH 1/2] conf: only accept capabilities mode hostdev in LXC.

2014-06-19 Thread Daniel P. Berrange
On Thu, Jun 19, 2014 at 05:45:12PM +0800, Jincheng Miao wrote: hostdev has mode capabilities for LXC, from formatdomain.html: Block / character devices from the host can be passed through to the guest using the hostdev element. This is only possible with container based virtualization.

Re: [libvirt] [PATCH 1/2] conf: only accept capabilities mode hostdev in LXC.

2014-06-19 Thread Jincheng Miao
- Original Message - No, the parser code is not supposed to do semantic validation like this. This kind of check should be done exclusively in the driver code which forms the command line args for the hypervisors which don't support it. Oh, I just understand why there is no hypervisor