Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier

2012-10-25 Thread Daniel Veillard
On Wed, Oct 24, 2012 at 03:31:24PM +0100, Daniel P. Berrange wrote: On Wed, Oct 24, 2012 at 08:30:02AM -0600, Eric Blake wrote: On 10/24/2012 03:20 AM, Daniel P. Berrange wrote: Agreed, and this is not the first time this has come up. However, the last time I attempted this, I ran into

Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier

2012-10-24 Thread Daniel P. Berrange
On Tue, Oct 23, 2012 at 12:01:02PM -0600, Eric Blake wrote: Commit 12ad7435 added new functions (virNodeGetMemoryParameters, virNodeSetMemoryParameters) into the section of the file reserved for deprecated names. Fix this by moving things earlier; split into two patches to make git diff

Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier

2012-10-24 Thread Daniel P. Berrange
On Wed, Oct 24, 2012 at 08:30:02AM -0600, Eric Blake wrote: On 10/24/2012 03:20 AM, Daniel P. Berrange wrote: On Tue, Oct 23, 2012 at 12:01:02PM -0600, Eric Blake wrote: Commit 12ad7435 added new functions (virNodeGetMemoryParameters, virNodeSetMemoryParameters) into the section of the file

Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier

2012-10-24 Thread Eric Blake
On 10/24/2012 03:20 AM, Daniel P. Berrange wrote: On Tue, Oct 23, 2012 at 12:01:02PM -0600, Eric Blake wrote: Commit 12ad7435 added new functions (virNodeGetMemoryParameters, virNodeSetMemoryParameters) into the section of the file reserved for deprecated names. Fix this by moving things

[libvirt] [PATCH 1/2] include: declare typed parameter handling earlier

2012-10-23 Thread Eric Blake
Commit 12ad7435 added new functions (virNodeGetMemoryParameters, virNodeSetMemoryParameters) into the section of the file reserved for deprecated names. Fix this by moving things earlier; split into two patches to make git diff easier to read. * include/libvirt/libvirt.h.in: Move

Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier

2012-10-23 Thread Laine Stump
On 10/23/2012 02:01 PM, Eric Blake wrote: Commit 12ad7435 added new functions (virNodeGetMemoryParameters, virNodeSetMemoryParameters) into the section of the file reserved for deprecated names. Fix this by moving things earlier; split into two patches to make git diff easier to read. *