Re: [libvirt] [PATCH 1/2] libvirtd.init: improve portability

2010-04-14 Thread Eric Blake
On 04/14/2010 10:24 AM, Jim Meyering wrote: > Eric Blake wrote: >> This patch kills translation of the daemon messages, but being a >> daemon, the messages probably didn't need translation in the first >> place. Other alternatives would be to make the script require >> >> * daemon/libvirtd.init.in

Re: [libvirt] [PATCH 1/2] libvirtd.init: improve portability

2010-04-14 Thread Jim Meyering
Eric Blake wrote: > This patch kills translation of the daemon messages, but being a > daemon, the messages probably didn't need translation in the first > place. Other alternatives would be to make the script require > > * daemon/libvirtd.init.in (start, stop, reload): Drop bash-ism of > $"". Us

Re: [libvirt] [PATCH 1/2] libvirtd.init: improve portability

2010-04-14 Thread Daniel P. Berrange
On Wed, Apr 14, 2010 at 09:53:30AM -0600, Eric Blake wrote: > This patch kills translation of the daemon messages, but being a > daemon, the messages probably didn't need translation in the first > place. Other alternatives would be to make the script require NACK, this current style, with transl

[libvirt] [PATCH 1/2] libvirtd.init: improve portability

2010-04-14 Thread Eric Blake
This patch kills translation of the daemon messages, but being a daemon, the messages probably didn't need translation in the first place. Other alternatives would be to make the script require * daemon/libvirtd.init.in (start, stop, reload): Drop bash-ism of $"". Use printf instead of echo -n.