Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

2017-12-04 Thread Jim Fehlig
On 12/04/2017 03:27 PM, Marek Marczykowski-Górecki wrote: On Mon, Dec 04, 2017 at 03:14:33PM -0700, Jim Fehlig wrote: On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote: On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: There's another instance of this check in xenFormatNet()

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

2017-12-04 Thread Marek Marczykowski-Górecki
On Mon, Dec 04, 2017 at 03:14:33PM -0700, Jim Fehlig wrote: > On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote: > > On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: > > > There's another instance of this check in xenFormatNet() in > > > src/xenconfig/xen_common.c. I suppose

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

2017-12-04 Thread Jim Fehlig
On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote: On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: There's another instance of this check in xenFormatNet() in src/xenconfig/xen_common.c. I suppose multiple IP addrs are not supported in xml <-> xl.cfg conversions. Do you have

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

2017-12-04 Thread Marek Marczykowski-Górecki
On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: > There's another instance of this check in xenFormatNet() in > src/xenconfig/xen_common.c. I suppose multiple IP addrs are not supported in > xml <-> xl.cfg conversions. Do you have time to fix the config converter > too? Where should I

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

2017-12-04 Thread Jim Fehlig
On 12/02/2017 07:35 PM, Marek Marczykowski-Górecki wrote: vif-* scripts support it for a long time, and expect addresses to be separated by spaces. Add appropriate support to libxl driver. --- src/libxl/libxl_conf.c | 29 +++-- src/libxl/libxl_domain.c | 12

[libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

2017-12-02 Thread Marek Marczykowski-Górecki
vif-* scripts support it for a long time, and expect addresses to be separated by spaces. Add appropriate support to libxl driver. --- src/libxl/libxl_conf.c | 29 +++-- src/libxl/libxl_domain.c | 12 2 files changed, 27 insertions(+), 14 deletions(-) diff