Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2016-01-22 Thread John Ferlan
On 01/12/2016 11:03 AM, Joe Harvell wrote: > Le 11/01/2016 17:32, John Ferlan a écrit : >> >> On 01/11/2016 12:50 PM, Joe Harvell wrote: John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2016-01-12 Thread Joe Harvell
Le 11/01/2016 17:32, John Ferlan a écrit : On 01/11/2016 12:50 PM, Joe Harvell wrote: John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here already submitted just over a year ago. I don't see any evidence of

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2016-01-11 Thread John Ferlan
On 01/11/2016 12:50 PM, Joe Harvell wrote: >> John/Jan: >> >> I actually made a patch similar to this and was about to submit it for >> review. Now I see there is a more thorough version here already >> submitted just over a year ago. I don't see any evidence of this in >> the git repo. Are

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2016-01-11 Thread Joe Harvell
John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here already submitted just over a year ago. I don't see any evidence of this in the git repo. Are there any plans to commit it? --- Joe Harvell --

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2016-01-11 Thread Joe Harvell
John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here already submitted just over a year ago. I don't see any evidence of this in the git repo. Are there any plans to commit it? --- Joe Harvell --

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2014-12-16 Thread Daniel P. Berrange
On Fri, Dec 12, 2014 at 04:14:29PM -0500, John Ferlan wrote: Commit id '1ffc78b5' was supposed to support for thin logical volumes; however, instead it added support for thin snapshot volumes. This worked fine for a few releases of LVM; however, more recent versions (not sure exactly which

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2014-12-16 Thread John Ferlan
On 12/16/2014 10:20 AM, Daniel P. Berrange wrote: On Fri, Dec 12, 2014 at 04:14:29PM -0500, John Ferlan wrote: ...snip... I'm unclear still on what the difference is between a thin snapshot (with no backing volume) and a thin volume ? I've asked that question of someone from lvm... The

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2014-12-15 Thread Ján Tomko
On 12/12/2014 10:14 PM, John Ferlan wrote: Commit id '1ffc78b5' was supposed to support for thin logical volumes; however, instead it added support for thin snapshot volumes. This worked fine for a few releases of LVM; however, more recent versions (not sure exactly which one) made a

[libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

2014-12-12 Thread John Ferlan
Commit id '1ffc78b5' was supposed to support for thin logical volumes; however, instead it added support for thin snapshot volumes. This worked fine for a few releases of LVM; however, more recent versions (not sure exactly which one) made a differentiation between a thin snapshot volume and a