Re: [libvirt] [PATCH 1/2] nodedev: sysfs: Set PCI_PHYSICAL_FUNCTION flag more carefully

2016-05-24 Thread Andrea Bolognani
On Mon, 2016-05-23 at 15:21 -0400, Laine Stump wrote: > On 05/23/2016 07:53 AM, Andrea Bolognani wrote: > >  > > The flag was set if virPCIGetPhysicalFunction() did not return > > an error; unfortunately, the 'physfn' sysfs file not being > > present is not considered an error, which means that

Re: [libvirt] [PATCH 1/2] nodedev: sysfs: Set PCI_PHYSICAL_FUNCTION flag more carefully

2016-05-23 Thread Laine Stump
On 05/23/2016 07:53 AM, Andrea Bolognani wrote: The flag was set if virPCIGetPhysicalFunction() did not return an error; unfortunately, the 'physfn' sysfs file not being present is not considered an error, which means that the flag was set pretty much unconditionally. This behavior is the

[libvirt] [PATCH 1/2] nodedev: sysfs: Set PCI_PHYSICAL_FUNCTION flag more carefully

2016-05-23 Thread Andrea Bolognani
The flag was set if virPCIGetPhysicalFunction() did not return an error; unfortunately, the 'physfn' sysfs file not being present is not considered an error, which means that the flag was set pretty much unconditionally. This, in turn, caused libvirtd to crash in virNodeDeviceDefFormat(), where