Re: [libvirt] [PATCH 1/2] qemu: Fix incorrect jump labels in error paths

2017-02-23 Thread Michal Privoznik
On 02/23/2017 04:57 PM, Marc Hartmayer wrote: > On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik > wrote: >> On 02/23/2017 10:44 AM, Marc Hartmayer wrote: >>> Fix incorrect jump labels in error paths as the stop jump is only >>> needed if the driver has already

Re: [libvirt] [PATCH 1/2] qemu: Fix incorrect jump labels in error paths

2017-02-23 Thread Marc Hartmayer
On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik wrote: > On 02/23/2017 10:44 AM, Marc Hartmayer wrote: >> Fix incorrect jump labels in error paths as the stop jump is only >> needed if the driver has already changed the state. For example >>

Re: [libvirt] [PATCH 1/2] qemu: Fix incorrect jump labels in error paths

2017-02-23 Thread Michal Privoznik
On 02/23/2017 10:44 AM, Marc Hartmayer wrote: > Fix incorrect jump labels in error paths as the stop jump is only > needed if the driver has already changed the state. For example > 'virAtomicIntInc(>nactive)' will be 'reverted' in the > qemuProcessStop call. > > Signed-off-by: Marc Hartmayer

[libvirt] [PATCH 1/2] qemu: Fix incorrect jump labels in error paths

2017-02-23 Thread Marc Hartmayer
Fix incorrect jump labels in error paths as the stop jump is only needed if the driver has already changed the state. For example 'virAtomicIntInc(>nactive)' will be 'reverted' in the qemuProcessStop call. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski