Re: [libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

2011-08-25 Thread Eric Blake
On 08/16/2011 03:24 AM, Alex Jia wrote: * src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence clang warning. Detected by ccc-analyzer: CC libvirt_driver_qemu_la-qemu_migration.lo qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read ret = qemuM

Re: [libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

2011-08-16 Thread Eric Blake
On 08/16/2011 04:02 AM, Osier Yang wrote: +++ b/src/qemu/qemu_migration.c @@ -2050,6 +2050,9 @@ finish: * do, but fortunately worst case is that there is a * domain left in 'paused' state on source. */ + if (ret< 0) + VIR_WARN("Guest %s probably left in 'paused' state on source", + vm->def->name)

Re: [libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

2011-08-16 Thread Osier Yang
于 2011年08月16日 17:24, Alex Jia 写道: * src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence clang warning. Detected by ccc-analyzer: CC libvirt_driver_qemu_la-qemu_migration.lo qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read ret = qemuMigrati

Re: [libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

2011-08-16 Thread Alex Jia
On 08/16/2011 06:02 PM, Osier Yang wrote: 于 2011年08月16日 17:24, Alex Jia 写道: * src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence clang warning. Detected by ccc-analyzer: CC libvirt_driver_qemu_la-qemu_migration.lo qemu/qemu_migration.c:2046:5: warning: Value stored to

[libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

2011-08-16 Thread ajia
* src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence clang warning. Detected by ccc-analyzer: CC libvirt_driver_qemu_la-qemu_migration.lo qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read ret = qemuMigrationConfirm(driver, sconn, vm, ^