Re: [libvirt] [PATCH 1/2] qemu: reserve PCI addresses for implicit i440fx devices

2017-10-11 Thread Andrea Bolognani
On Wed, 2017-10-11 at 14:45 +0200, Ján Tomko wrote: > > I think it would make more sense to reserve the address for these > > devices in qemuDomainCollectPCIAddress() directly, along with the > > other ones, eg. squash in the following diff: > > > > -- 8< -- 8< -- 8< --

Re: [libvirt] [PATCH 1/2] qemu: reserve PCI addresses for implicit i440fx devices

2017-10-11 Thread Ján Tomko
On Wed, Oct 11, 2017 at 01:14:58PM +0200, Andrea Bolognani wrote: On Tue, 2017-09-26 at 13:05 +0200, Ján Tomko wrote: @@ -1429,15 +1429,24 @@ qemuDomainValidateDevicePCISlotsPIIX3(virDomainDefPtr def, cont->info.addr.pci.slot = 1; cont->info.addr.pci.function =

Re: [libvirt] [PATCH 1/2] qemu: reserve PCI addresses for implicit i440fx devices

2017-10-11 Thread Andrea Bolognani
On Tue, 2017-09-26 at 13:05 +0200, Ján Tomko wrote: > @@ -1429,15 +1429,24 @@ qemuDomainValidateDevicePCISlotsPIIX3(virDomainDefPtr > def, > cont->info.addr.pci.slot = 1; > cont->info.addr.pci.function = 2; > } > +} else { > +/* th

Re: [libvirt] [PATCH 1/2] qemu: reserve PCI addresses for implicit i440fx devices

2017-10-05 Thread John Ferlan
On 09/26/2017 07:05 AM, Ján Tomko wrote: > Somewhere around commit 9ff9d9f reserving entire PCI slots was > eliminated, as demonstrated by commit 6cc2014. > > Reserve the functions required by the implicit devices: > 00:01.0 ISA Bridge > 00:01.1 IDE Controller > 00:01.2 USB Controller (unless US

[libvirt] [PATCH 1/2] qemu: reserve PCI addresses for implicit i440fx devices

2017-09-26 Thread Ján Tomko
Somewhere around commit 9ff9d9f reserving entire PCI slots was eliminated, as demonstrated by commit 6cc2014. Reserve the functions required by the implicit devices: 00:01.0 ISA Bridge 00:01.1 IDE Controller 00:01.2 USB Controller (unless USB is disabled) 00:01.3 Bridge https://bugzilla.redhat.co