Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Guannan Ren
On 10/17/2012 11:39 PM, Laine Stump wrote: On 10/16/2012 11:32 PM, Guannan Ren wrote: It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced t

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Laine Stump
On 10/16/2012 11:32 PM, Guannan Ren wrote: > It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT > rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE > (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug) > --- > src/qemu/qemu_command.

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Guannan Ren
On 10/17/2012 04:30 PM, Daniel P. Berrange wrote: On Wed, Oct 17, 2012 at 11:32:45AM +0800, Guannan Ren wrote: It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4923d0b32e83d4ca96

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Daniel P. Berrange
On Wed, Oct 17, 2012 at 11:32:45AM +0800, Guannan Ren wrote: > It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT > rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE > (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug) Why ? IMHO,

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-16 Thread Guannan Ren
On 10/17/2012 11:32 AM, Guannan Ren wrote: It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug) --- src/qemu/qemu_command.c | 8 +

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-16 Thread Guannan Ren
On 10/17/2012 11:57 AM, Eric Blake wrote: On 10/16/2012 09:32 PM, Guannan Ren wrote: In the subject: s/relablling/relabeling/ It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-16 Thread Eric Blake
On 10/16/2012 09:32 PM, Guannan Ren wrote: In the subject: s/relablling/relabeling/ > It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT > rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE > (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduce

[libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-16 Thread Guannan Ren
It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug) --- src/qemu/qemu_command.c | 8 1 file changed, 4 insertions(+), 4 de