Re: [libvirt] [PATCH 1/2] snapshot: let virsh edit disk snapshots

2011-10-07 Thread Eric Blake
On 10/07/2011 08:13 AM, Daniel Veillard wrote: On Thu, Oct 06, 2011 at 05:18:33PM -0600, Eric Blake wrote: It was impossible for 'virsh snapshot-current dom name' to set name as the current snapshot, if name is a disk-only snapshot. Using strstr rather than full-blown xml parsing is safe, since

Re: [libvirt] [PATCH 1/2] snapshot: let virsh edit disk snapshots

2011-10-07 Thread Daniel Veillard
On Thu, Oct 06, 2011 at 05:18:33PM -0600, Eric Blake wrote: > It was impossible for 'virsh snapshot-current dom name' to set name > as the current snapshot, if name is a disk-only snapshot. > > Using strstr rather than full-blown xml parsing is safe, since the > xml is assumed to be well-formed co

[libvirt] [PATCH 1/2] snapshot: let virsh edit disk snapshots

2011-10-06 Thread Eric Blake
It was impossible for 'virsh snapshot-current dom name' to set name as the current snapshot, if name is a disk-only snapshot. Using strstr rather than full-blown xml parsing is safe, since the xml is assumed to be well-formed coming from libvirtd rather than arbitrary text coming from the user. *