Re: [libvirt] [PATCH 1/2] tools: console: cleanup console on errors in main thread

2019-02-25 Thread Nikolay Shirokovskiy
On 22.02.2019 17:55, John Ferlan wrote: > > > On 2/15/19 9:39 AM, Nikolay Shirokovskiy wrote: >> We only check now for virObjectWait failures in virshRunConsole but >> we'd better check and for other failures too. Anyway if failure >> happened we need to shutdown console to stop delivering

Re: [libvirt] [PATCH 1/2] tools: console: cleanup console on errors in main thread

2019-02-22 Thread John Ferlan
On 2/15/19 9:39 AM, Nikolay Shirokovskiy wrote: > We only check now for virObjectWait failures in virshRunConsole but > we'd better check and for other failures too. Anyway if failure > happened we need to shutdown console to stop delivering events > from event loop thread or we are in trouble

[libvirt] [PATCH 1/2] tools: console: cleanup console on errors in main thread

2019-02-15 Thread Nikolay Shirokovskiy
We only check now for virObjectWait failures in virshRunConsole but we'd better check and for other failures too. Anyway if failure happened we need to shutdown console to stop delivering events from event loop thread or we are in trouble as console is freed on virshRunConsole exit. And we need