Re: [libvirt] [PATCH 1/2] virDomainDiskSourceFormatInternal: Avoid leaking @childBuf

2018-02-20 Thread Daniel P . Berrangé
On Tue, Feb 20, 2018 at 12:30:31PM +0100, Michal Privoznik wrote: > If formatting of storage encryption or private data fails we must > jump to the error label instead of returning immediately > otherwise @attrBuf and @childBuf might be leaked. > > Signed-off-by: Michal Privoznik > --- > src/con

[libvirt] [PATCH 1/2] virDomainDiskSourceFormatInternal: Avoid leaking @childBuf

2018-02-20 Thread Michal Privoznik
If formatting of storage encryption or private data fails we must jump to the error label instead of returning immediately otherwise @attrBuf and @childBuf might be leaked. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff