Re: [libvirt] [PATCH 1/2] virpci: simplify virPCIDeviceBindToStub

2016-08-01 Thread Jim Fehlig
On 07/28/2016 06:01 PM, Laine Stump wrote: > On 07/11/2016 02:23 PM, Jim Fehlig wrote: >> Early in virPCIDeviceBindToStub, there is a check to see if the >> stub is already bound to the device, returning success with no >> further actions if that is the case. >> >> The same condition is

Re: [libvirt] [PATCH 1/2] virpci: simplify virPCIDeviceBindToStub

2016-07-28 Thread Laine Stump
On 07/11/2016 02:23 PM, Jim Fehlig wrote: Early in virPCIDeviceBindToStub, there is a check to see if the stub is already bound to the device, returning success with no further actions if that is the case. The same condition is unnecessarily checked later in the function. Looking at the

[libvirt] [PATCH 1/2] virpci: simplify virPCIDeviceBindToStub

2016-07-11 Thread Jim Fehlig
Early in virPCIDeviceBindToStub, there is a check to see if the stub is already bound to the device, returning success with no further actions if that is the case. The same condition is unnecessarily checked later in the function. Remove the unneeded checks to simplify the logic a bit.