Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-10 Thread Guido Günther
On Fri, Oct 07, 2011 at 12:18:51PM +0200, Guido Günther wrote: On Thu, Oct 06, 2011 at 04:33:49PM -0600, Eric Blake wrote: On 10/06/2011 11:36 AM, Guido Günther wrote: These three errors should probably all be changed away from VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-10 Thread Eric Blake
On 10/07/2011 04:18 AM, Guido Günther wrote: ACK to the concept, once we decide on the correct error code. I think we've decided. (Hopefully) final version attached. I've left the first error as INTERNAL_ERROR since this it's there do detect false function parameters. Yes, you got that

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-10 Thread Guido Günther
On Mon, Oct 10, 2011 at 01:23:20PM -0600, Eric Blake wrote: On 10/07/2011 04:18 AM, Guido Günther wrote: ACK to the concept, once we decide on the correct error code. I think we've decided. (Hopefully) final version attached. I've left the first error as INTERNAL_ERROR since this it's

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-07 Thread Guido Günther
On Thu, Oct 06, 2011 at 04:33:49PM -0600, Eric Blake wrote: On 10/06/2011 11:36 AM, Guido Günther wrote: These three errors should probably all be changed away from VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not sure whether that would be VIR_ERR_CONF_SYNTAX,

[libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-06 Thread Guido Günther
otherwise a missing UUID in a domain config just shows: libxlDomainXMLFromNative:2600 : Internal Error parsing xm config failed Now we have: xenXMConfigGetUUID:186 : Internal Error config value uuid was missing O.k. to apply? -- Guido --- src/xenxs/xen_xm.c | 37

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-06 Thread Eric Blake
On 10/06/2011 03:15 AM, Guido Günther wrote: otherwise a missing UUID in a domain config just shows: libxlDomainXMLFromNative:2600 : Internal Error parsing xm config failed Now we have: xenXMConfigGetUUID:186 : Internal Error config value uuid was missing Still doesn't sound quite right -

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-06 Thread Guido Günther
Hi Eric, On Thu, Oct 06, 2011 at 10:50:46AM -0600, Eric Blake wrote: On 10/06/2011 03:15 AM, Guido Günther wrote: otherwise a missing UUID in a domain config just shows: libxlDomainXMLFromNative:2600 : Internal Error parsing xm config failed Now we have: xenXMConfigGetUUID:186 :

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-06 Thread Laine Stump
On 10/06/2011 01:36 PM, Guido Günther wrote: Hi Eric, On Thu, Oct 06, 2011 at 10:50:46AM -0600, Eric Blake wrote: These three errors should probably all be changed away from VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not sure whether that would be VIR_ERR_CONF_SYNTAX,

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-06 Thread Guido Günther
On Thu, Oct 06, 2011 at 03:55:48PM -0400, Laine Stump wrote: On 10/06/2011 01:36 PM, Guido Günther wrote: Hi Eric, On Thu, Oct 06, 2011 at 10:50:46AM -0600, Eric Blake wrote: These three errors should probably all be changed away from VIR_ERR_INTERNAL_ERROR into something more useful, but

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-06 Thread Eric Blake
On 10/06/2011 11:36 AM, Guido Günther wrote: These three errors should probably all be changed away from VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not sure whether that would be VIR_ERR_CONF_SYNTAX, VIR_ERR_CONFIG_UNSUPPORTED, or something else. I was uncertain about the error