Re: [libvirt] [PATCH 1/3] Add field to virDomainObjPtr to track "tainting"

2011-05-04 Thread Eric Blake
On 05/04/2011 05:28 AM, Daniel P. Berrange wrote: > +bool virDomainObjTaint(virDomainObjPtr obj, > + int taint) > +{ > +int flag = (1 << taint); Undefined behavior if taint is out of bounds (>= 31). Do we need a sanity check, or to change the 'int taint' parameter to ins

[libvirt] [PATCH 1/3] Add field to virDomainObjPtr to track "tainting"

2011-05-04 Thread Daniel P. Berrange
Some configuration setups for guests are allowed, but strongly discouraged and unsupportable in production systems. Introduce a concept of 'tainting' to virDomainObjPtr to allow such setups to be identified. Drivers can then log warnings at suitable times * src/conf/domain_conf.c, src/conf/domain_