Re: [libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-17 Thread Benjamin Cama
Hi everyone, Le lundi 15 octobre 2012 à 09:36 -0700, Cole Robinson a écrit : > On 10/15/2012 12:04 PM, Cole Robinson wrote: > > On 10/15/2012 10:54 AM, Michal Privoznik wrote: > >> On 15.10.2012 12:26, Benjamin Cama wrote: > >>> > >>> static int > >>> networkSetIPv6Sysctls(virNetworkObjPtr net

Re: [libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-15 Thread Laine Stump
On 10/15/2012 12:04 PM, Cole Robinson wrote: > On 10/15/2012 10:54 AM, Michal Privoznik wrote: >> On 15.10.2012 12:26, Benjamin Cama wrote: >>> >>> static int >>> networkSetIPv6Sysctls(virNetworkObjPtr network) >>> @@ -2140,11 +2172,9 @@ networkStartNetworkVirtual(struct network_driver >>> *dr

Re: [libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-15 Thread Cole Robinson
On 10/15/2012 10:54 AM, Michal Privoznik wrote: > On 15.10.2012 12:26, Benjamin Cama wrote: >> >> static int >> networkSetIPv6Sysctls(virNetworkObjPtr network) >> @@ -2140,11 +2172,9 @@ networkStartNetworkVirtual(struct network_driver >> *driver, >> if (virNetDevSetOnline(network->def->b

Re: [libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-15 Thread Michal Privoznik
On 15.10.2012 12:26, Benjamin Cama wrote: > Enabling IP forwarding without the administrator's consent is bad. Only > check for forwarding, do not enable it. > --- > src/network/bridge_driver.c | 56 > +-- > 1 files changed, 43 insertions(+), 13 deletions

[libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-15 Thread Benjamin Cama
Enabling IP forwarding without the administrator's consent is bad. Only check for forwarding, do not enable it. --- src/network/bridge_driver.c | 56 +-- 1 files changed, 43 insertions(+), 13 deletions(-) diff --git a/src/network/bridge_driver.c b/src/net