Re: [libvirt] [PATCH 1/3] Report full errors from virCgroupNew*

2013-07-19 Thread Daniel P. Berrange
On Thu, Jul 18, 2013 at 09:15:28PM -0600, Eric Blake wrote: On 07/18/2013 09:00 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Instead of returning raw errno values, report full libvirt errors in virCgroupNew* functions. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 1/3] Report full errors from virCgroupNew*

2013-07-19 Thread Daniel P. Berrange
On Thu, Jul 18, 2013 at 09:15:28PM -0600, Eric Blake wrote: On 07/18/2013 09:00 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Instead of returning raw errno values, report full libvirt errors in virCgroupNew* functions. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 1/3] Report full errors from virCgroupNew*

2013-07-19 Thread Eric Blake
On 07/19/2013 08:34 AM, Daniel P. Berrange wrote: Overall, looks like a decent improvement. I pointed out a few things worth cleaning up, and the idea of splitting into two patches may have merit. It may be faster to post the changes you will squash in than a full-blown v2, considering the

Re: [libvirt] [PATCH 1/3] Report full errors from virCgroupNew*

2013-07-18 Thread Eric Blake
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Instead of returning raw errno values, report full libvirt errors in virCgroupNew* functions. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/libvirt_private.syms | 1 +