Re: [libvirt] [PATCH 1/3] conf: Add rom.enabled attribute for PCI devices

2018-04-23 Thread Peter Krempa
On Mon, Apr 23, 2018 at 11:10:01 +0200, Andrea Bolognani wrote: > On Mon, 2018-04-23 at 08:53 +0200, Peter Krempa wrote: > > > +The optional enabled attribute can be set to > > > +no to disable PCI ROM loading completely for the > > > device. > > > +Since 4.3.0 (QEMU and KV

Re: [libvirt] [PATCH 1/3] conf: Add rom.enabled attribute for PCI devices

2018-04-23 Thread Andrea Bolognani
On Mon, 2018-04-23 at 08:53 +0200, Peter Krempa wrote: > > +The optional enabled attribute can be set to > > +no to disable PCI ROM loading completely for the > > device. > > +Since 4.3.0 (QEMU and KVM only). > > Maybe you should mention that any other configration may not

Re: [libvirt] [PATCH 1/3] conf: Add rom.enabled attribute for PCI devices

2018-04-22 Thread Peter Krempa
On Fri, Apr 20, 2018 at 17:44:29 +0200, Andrea Bolognani wrote: > The attribute can be used to disable ROM loading completely > for a device. > > Signed-off-by: Andrea Bolognani > --- > docs/formatdomain.html.in | 3 +++ > docs/schemas/domaincommon.rng | 5 + > src/conf/device_conf.h

[libvirt] [PATCH 1/3] conf: Add rom.enabled attribute for PCI devices

2018-04-20 Thread Andrea Bolognani
The attribute can be used to disable ROM loading completely for a device. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 3 +++ docs/schemas/domaincommon.rng | 5 + src/conf/device_conf.h| 1 + src/conf/domain_conf.c| 26 +- 4 f